launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Badin has proposed merging lp:~rvb/maas/empty-result into lp:maas.

Commit message:
Allow NodeCommissionResult.data to be empty.  This happens when a commissioning script outputs nothing.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~rvb/maas/empty-result/+merge/140727
-- 
https://code.launchpad.net/~rvb/maas/empty-result/+merge/140727
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/empty-result into lp:maas.

=== modified file 'src/metadataserver/models/nodecommissionresult.py'
--- src/metadataserver/models/nodecommissionresult.py	2012-12-19 12:23:48 +0000
+++ src/metadataserver/models/nodecommissionresult.py	2012-12-19 16:41:21 +0000
@@ -73,4 +73,5 @@
         'maasserver.Node', null=False, editable=False, unique=False)
     script_result = IntegerField(editable=False)
     name = CharField(max_length=255, unique=False, editable=False)
-    data = CharField(max_length=1024 * 1024, editable=True)
+    data = CharField(
+        max_length=1024 * 1024, editable=True, blank=True, default='')