launchpad-reviewers team mailing list archive

[Andres Rodriguez <andreserl@xxxxxxxxxxxxx>]

Andres Rodriguez has proposed merging lp:~andreserl/maas/maas_ipmi_lan2.0 into lp:maas.

Commit message:
Enforce IPMI 2.0 authentication (LP: #1086162)

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1086162 in MAAS: "IPMI based power management default to IPMI 1.5 based authentication"
  https://bugs.launchpad.net/maas/+bug/1086162

For more details, see:
https://code.launchpad.net/~andreserl/maas/maas_ipmi_lan2.0/+merge/140922
-- 
https://code.launchpad.net/~andreserl/maas/maas_ipmi_lan2.0/+merge/140922
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~andreserl/maas/maas_ipmi_lan2.0 into lp:maas.

=== modified file 'src/provisioningserver/power/templates/ipmi.template'
--- src/provisioningserver/power/templates/ipmi.template	2012-10-06 16:23:49 +0000
+++ src/provisioningserver/power/templates/ipmi.template	2012-12-20 15:07:32 +0000
@@ -42,9 +42,9 @@
 issue_ipmi_command() {
     # See https://launchpad.net/bugs/1053391 for details of this workaround
     echo workaround |\
-    ${ipmi_chassis_config} -h ${power_address} -u ${power_user} -p ${power_pass} --commit --filename ${config}
+    ${ipmi_chassis_config} -D LAN_2_0 -h ${power_address} -u ${power_user} -p ${power_pass} --commit --filename ${config}
     echo workaround |\
-    ${ipmipower} -h ${power_address} -u ${power_user} -p ${power_pass} "$@"
+    ${ipmipower} -D LAN_2_0 -h ${power_address} -u ${power_user} -p ${power_pass} "$@"
 }