launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/librarian-last-accessed into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #4613 in Launchpad itself: "Librarian does not update LibraryFileAlias.last_accessed"
  https://bugs.launchpad.net/launchpad/+bug/4613
  Bug #86171 in Launchpad itself: "LibraryFileAlias.last_accessed is not being updated"
  https://bugs.launchpad.net/launchpad/+bug/86171
  Bug #1092332 in Launchpad itself: "Drop LibraryFileAlias.last_accessed"
  https://bugs.launchpad.net/launchpad/+bug/1092332

For more details, see:
https://code.launchpad.net/~stub/launchpad/librarian-last-accessed/+merge/140908

= Summary =

Per Bug #1092332, LibraryFileAlias.last_accessed is a waste of space.

== Proposed fix ==

Stop all code from accessing it, dropping the column in a separate branch.

== Pre-implementation notes ==

== LOC Rationale ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/librarianserver/web.py
  lib/lp/services/librarian/model.py
  lib/lp/services/librarianserver/tests/test_web.py
  lib/lp/services/librarian/interfaces/__init__.py
  lib/lp/services/librarianserver/tests/test_gc.py
  database/schema/patch-2209-40-3.sql
  lib/lp/services/librarianserver/librariangc.py

./lib/lp/services/librarianserver/tests/test_web.py
      73: E225 missing whitespace around operator
     179: E225 missing whitespace around operator
     245: E225 missing whitespace around operator
     256: E225 missing whitespace around operator
     265: E225 missing whitespace around operator
     267: E225 missing whitespace around operator
     331: E225 missing whitespace around operator
     342: E225 missing whitespace around operator
     344: E225 missing whitespace around operator
-- 
https://code.launchpad.net/~stub/launchpad/librarian-last-accessed/+merge/140908
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/librarian-last-accessed into lp:launchpad.