launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve db

You have a huge diff as PostgreSQL 9.1.4 was used to regenerate the sampledata, but you need 9.1.6 or 9.1.7.

The DB patch is fine.

Are you sure an integer is the correct datatype, or would a floating point be better? I'm unsure if people would want to use this feature for <1% of users (even though that is significant when dealing with hundreds of thousands or millions).
-- 
https://code.launchpad.net/~cjwatson/launchpad/db-bpph-phase/+merge/143673
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/db-bpph-phase into lp:launchpad/db-devel.