launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Okay, you've sold me: I'll import gocheck using "." from now on.

As for the long test setup, there's a lot of server/client setup that looks repetitive.  It's not particularly tightly coupled, so a helper to make a client, server, and single-serving http server may seem a bit arbitrary.  But maybe you won't need all 3 as return values that way, and in that case I think it would be justifiable.


Jeroen
-- 
https://code.launchpad.net/~rvb/maas/gomaasapi-listnodes/+merge/144654
Your team MAAS Maintainers is subscribed to branch lp:~maas-maintainers/maas/gomaasapi.