launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Review: Approve

LGTM.

[0]

33	+// Join a base URL and a subpath together.
34	+// Regardless of whether base_url ends in a trailing slash (or even multiple

I think it's a practice in Go to start the "docstring" of a method using the name of the method (I /think/ I saw that in the doc) => "JoinURLs joins a base URL and a subpath together."

[1]

37	+func JoinURLs(base_url, path string) string {


Shouldn't we use camelCase for variable names? base_url => baseURL
-- 
https://code.launchpad.net/~jtv/maas/gomaasapi-urljoin/+merge/145131
Your team MAAS Maintainers is subscribed to branch lp:~maas-maintainers/maas/gomaasapi.