← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~rvb/maas/gomaasapi-baseURL into lp:~maas-maintainers/maas/gomaasapi

 

The proposal to merge lp:~rvb/maas/gomaasapi-baseURL into lp:~maas-maintainers/maas/gomaasapi has been updated.

Description changed to:

- Base URL is now a field in the Client objects (and not the Server object [i.e. a maasobject representing a MAAS server]).
- use url.URL internally to manipulate url objects.
- AppendSlash allows us, when using GetSubObject, to create urls ending with a slash.  This is to keep Django [as configured by MAAS] happy (see https://docs.djangoproject.com/en/dev/ref/settings/#append-slash for details).
- Drive-by fix: rename server.go => maas.go / server_test.go => maas_test.go.

For more details, see:
https://code.launchpad.net/~rvb/maas/gomaasapi-baseURL/+merge/145180
-- 
https://code.launchpad.net/~rvb/maas/gomaasapi-baseURL/+merge/145180
Your team MAAS Maintainers is requested to review the proposed merge of lp:~rvb/maas/gomaasapi-baseURL into lp:~maas-maintainers/maas/gomaasapi.


References