launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~rvb/maas/gomaasapi-baseURL into lp:~maas-maintainers/maas/gomaasapi

To: mp+145180@xxxxxxxxxxxxxxxxxx
From: "Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>
Date: Tue, 29 Jan 2013 08:20:35 -0000
In-reply-to: <20130128140552.7038.70201.launchpad@ackee.canonical.com>
Reply-to: mp+145180@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

As long as there is some prior verification that resource_uri is a string *and* parses correctly as a URL, I agree that we should be able to just panic if the parsing fails later on.  If it makes things simpler (not meant as an optimization!) we could just parse and store the URL right away when we create a new jsonMAASObject.
-- 
https://code.launchpad.net/~rvb/maas/gomaasapi-baseURL/+merge/145180
Your team MAAS Maintainers is subscribed to branch lp:~maas-maintainers/maas/gomaasapi.

References

[Merge] lp:~rvb/maas/gomaasapi-baseURL into lp:~maas-maintainers/maas/gomaasapi
From: Raphaël Badin, 2013-01-28