launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/bug-1116700 into lp:maas has been updated.

Commit Message changed to:

Generate CNAME for a node's oldest MACAddress that has a lease.  (Used to generate a CNAME for a node's oldest MACAddress *if it had* a lease).

We don't know why the code was originally written this way, although it was deliberate at the time (originally proposed at https://code.launchpad.net/~rvb/maas/maas-dns2/+merge/114707 ).  Our best recollection now is that it was done that way to mimick how things worked with Cobbler, but it led to problems when network interfaces weren't in the expected order.

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-1116700/+merge/146835
-- 
https://code.launchpad.net/~jtv/maas/bug-1116700/+merge/146835
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-1116700 into lp:maas.