launchpad-reviewers team mailing list archive

[Andres Rodriguez <andreserl@xxxxxxxxxxxxx>]

While I agree that the preseeds are untested, I don't agree that in this particular scenario  tested code would have helped as your comment seems to imply. The reason of this bug/branch is far from being unstested or, is possibility of discovery is far from being that case.

This is present due to the implementation differences between iLO versions (which is this case applies for 1.X and 2.X), and which differs from the latest 3.X.

Now, in favor of having things like this tested, you would either have to test it in different proper hardware, or simulate the implementations to perform the accurate tests.
-- 
https://code.launchpad.net/~andreserl/maas/ipmi_usercreation_ilo_versions/+merge/147460
Your team MAAS Maintainers is requested to review the proposed merge of lp:~andreserl/maas/ipmi_usercreation_ilo_versions into lp:maas/1.2.