launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/new-branch-search into lp:launchpad has been updated.

Description changed to:

Destroy the current branch search paradigm. Unfortunately, now I can't finish this description since I've killed myself for using the word 'paradigm'.

IBranchCollection.search(), and its exact match friend have been torched and sadly burnt to the ground. I have rewritten them to only match against Branch.name, with a few shortcuts that will return singular branches if it matches a URL (any of Branch.url, https://code.launchpad... or http://bazaar.launchpad...), lp: shortform URL or unique_name.

IBranchCollection.relatedTo() was caught by a backdraft and also burnt to the ground. Since only one test used it, I left it as a pile of cinders, and fixed the test.

I have refactored the branch vocabularies to no longer rely on a useless base
class, and cleaned up some whitespace and such.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/new-branch-search/+merge/147840
-- 
https://code.launchpad.net/~stevenk/launchpad/new-branch-search/+merge/147840
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/new-branch-search into lp:launchpad.