launchpad-reviewers team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

Review: Needs Fixing

Andres,
  Thanks for looking at this.  I think the implementation seems generally correct, and I suspect you've tested.
  However, I'd like 2 things
a.) since this is non straight forward when you look at it, could you add some comments explaining why you're doing what you're doing?
b.) this really probably should have a bug associated with it (sorry for that nit pick, but in absence of comments, I'd go looking for a bug to read about what was going on).
-- 
https://code.launchpad.net/~andreserl/maas/ipmi_usercreation_ilo_versions_trunk/+merge/148579
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~andreserl/maas/ipmi_usercreation_ilo_versions_trunk into lp:maas.