← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~stevenk/launchpad/new-perm-for-archive-subscribers-fixed into lp:launchpad

 

The proposal to merge lp:~stevenk/launchpad/new-perm-for-archive-subscribers-fixed into lp:launchpad has been updated.

Description changed to:

Fix SubscriberView for archives. Rewrite ViewSPPH to respect either SubscriberView or View, rather than delegating to Archive entirely. Shift IArchive.archive_url and IArchive.dependencies to SubscriberView.

Grow forwardCheckUnauthenticated on AuthorizationBase, and make use of it in two security adapters, rather than using check_permission, which makes use of global state.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/new-perm-for-archive-subscribers-fixed/+merge/149464
-- 
https://code.launchpad.net/~stevenk/launchpad/new-perm-for-archive-subscribers-fixed/+merge/149464
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/new-perm-for-archive-subscribers-fixed into lp:launchpad.


References