launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~michael.nelson/launchpad/include-binary-size into lp:launchpad

To: mp+150831@xxxxxxxxxxxxxxxxxx
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Feb 2013 23:32:21 -0000
In-reply-to: <20130227172026.17386.97423.launchpad@ackee.canonical.com>
Reply-to: mp+150831@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

I'd like to see a query count test, since you're now accessing more subordinate objects. It happens to be OK now because BPPH.files prejoins LFA/LFC, but a test like http://pastebin.ubuntu.com/5574906/ will ensure that performance doesn't regress.
-- 
https://code.launchpad.net/~michael.nelson/launchpad/include-binary-size/+merge/150831
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~michael.nelson/launchpad/include-binary-size into lp:launchpad.

References

[Merge] lp:~michael.nelson/launchpad/include-binary-size into lp:launchpad
From: Michael Nelson, 2013-02-27