launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/notify-when-spec-renamed into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1137102 in Launchpad itself: "Renaming blueprints should E-Mail subscribers about the change"
  https://bugs.launchpad.net/launchpad/+bug/1137102

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/notify-when-spec-renamed/+merge/151419

Also notify by mail when a specification's name changes. I am quite sad about the lack of tests for any of the blueprint notification functions.
-- 
https://code.launchpad.net/~stevenk/launchpad/notify-when-spec-renamed/+merge/151419
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/notify-when-spec-renamed into lp:launchpad.

=== modified file 'lib/lp/blueprints/mail/notifications.py'
--- lib/lp/blueprints/mail/notifications.py	2012-03-20 13:03:46 +0000
+++ lib/lp/blueprints/mail/notifications.py	2013-03-04 06:17:22 +0000
@@ -36,7 +36,7 @@
     subject = specification_notification_subject(spec)
     indent = ' ' * 4
     info_lines = []
-    for dbitem_name in ('definition_status', 'priority'):
+    for dbitem_name in ('name', 'definition_status', 'priority'):
         title = ISpecification[dbitem_name].title
         assert ISpecification[dbitem_name].required, (
             "The mail notification assumes %s can't be None" % dbitem_name)