launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~matsubara/maas/set-proxy into lp:~maas-maintainers/maas/qa-lab-tests

To: Diogo Matsubara <matsubara@xxxxxxxxxxxxx>
From: Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>
Date: Mon, 04 Mar 2013 16:09:18 -0000
In-reply-to: <20130228185027.9220.46543.launchpad@ackee.canonical.com>
Reply-to: mp+151074@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

This is a bit weird because:
- this is not testing anything, just setting a parameter, so maybe it should just be a helper method.
- this uses a feature that is only present in trunk but this code runs on packages built from 1.2 as well… it won't blow up in 1.2 but it will set a config item that is not used anywhere.
-- 
https://code.launchpad.net/~matsubara/maas/set-proxy/+merge/151074
Your team MAAS Maintainers is requested to review the proposed merge of lp:~matsubara/maas/set-proxy into lp:~maas-maintainers/maas/qa-lab-tests.

References

[Merge] lp:~matsubara/maas/set-proxy into lp:~maas-maintainers/maas/qa-lab-tests
From: Diogo Matsubara, 2013-02-28