launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/notify-when-spec-renamed-redux into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1137102 in Launchpad itself: "Renaming blueprints should E-Mail subscribers about the change"
  https://bugs.launchpad.net/launchpad/+bug/1137102

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/notify-when-spec-renamed-redux/+merge/151678

Turns out the change for this bug does not work, and the existing code for was enums only. I've moved it out and tested it works locally.
-- 
https://code.launchpad.net/~stevenk/launchpad/notify-when-spec-renamed-redux/+merge/151678
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/notify-when-spec-renamed-redux into lp:launchpad.

=== modified file 'lib/lp/blueprints/mail/notifications.py'
--- lib/lp/blueprints/mail/notifications.py	2013-03-04 06:11:42 +0000
+++ lib/lp/blueprints/mail/notifications.py	2013-03-05 04:35:24 +0000
@@ -36,7 +36,10 @@
     subject = specification_notification_subject(spec)
     indent = ' ' * 4
     info_lines = []
-    for dbitem_name in ('name', 'definition_status', 'priority'):
+    if spec_delta.name:
+        info_lines.append('%sname: %s => %s' % (
+            indent, spec_delta.name['old'], spec_delta.name['new']))
+    for dbitem_name in ('definition_status', 'priority'):
         title = ISpecification[dbitem_name].title
         assert ISpecification[dbitem_name].required, (
             "The mail notification assumes %s can't be None" % dbitem_name)