launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

> > ... I'll make the legacy user similar to the other system users, in
> > that it won't have a UserProfile. Then I can check that here and
> > raise an exception if it appears to be a regular user with the same
> > name.
> 
> Actually, I'm not 100% sure this is a good idea. The legacy user needs
> to be the same as a regular user. It's not unreasonable for someone to
> set its password and log-in to the web UI, at which point the lack of
> a UserProfile will cause problems, I think.

Indeed, you're right, I lost track of that.  (I think we need a profile to log in the UI so a user probably won't be able to log in, but as you pointed out, this is a problem.)

> 
> I'm inclined to either (a) not check or (b) check only that the user's
> full name is "Shared Environment".

b) does not feel very precise :/
-- 
https://code.launchpad.net/~allenap/maas/shared-to-per-tenant-storage/+merge/151858
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/shared-to-per-tenant-storage into lp:maas.