launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/person-deactivate-job into lp:launchpad has been updated.

Description changed to:

Create a new job, PersonDeactivateJob that will perform the unbounded heavy lifting of a deactivating a person, rather than attempting to have it all done in the webapp and constantly failing.

I have renamed IPerson.deactivateAccount() to just IPerson.deactivate(), as well as collapsing IPerson.canDeactivateAccount() and IPerson.canDeactivateAccountWithErrors() to just IPerson.canDeactivate(), and also cleaned them both up.

Person:+deactive now does the easy portions such as setting e-mail addresses to NEW, and the accountstatus to DEACTIVATED, and then creates a PDJ to perform the unbounded work.

Since minor_person for PersonTransferJob is mandatory, I have set it to the janitor, but it will not be referenced by the job when run, and have noted in a comment during job creation.

I've also cleaned up some lint and some whitespace.

I have more than enough LoC spare for this branch.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/person-deactivate-job/+merge/152809
-- 
https://code.launchpad.net/~stevenk/launchpad/person-deactivate-job/+merge/152809
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/person-deactivate-job into lp:launchpad.