launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/validate-milestone-tags into lp:launchpad has been updated.

Description changed to:

Validate tags during {Product,Distribution}Series:+addmilestone, Milestone:+edit, and IMilestone.setTags(), rather than relying on the database constraint firing which will result in an OOPS.

Now that we do validate tags, this also necessitated some test changes -- uppercase tags are now marked as invalid, but the code always forced them to lowercase anyway. Single letter tags are also not allowed any more, but they didn't seem to trip up the database constraint, but valid_name() loves them not.

I also moved validate_tags() from milestone's browser code, and put it with milestonetag's model code, since the places that were pulling it in import from there anyway.

Deal with some whitespace.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/validate-milestone-tags/+merge/155171
-- 
https://code.launchpad.net/~stevenk/launchpad/validate-milestone-tags/+merge/155171
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/validate-milestone-tags into lp:launchpad.