launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/juju-core/instanceID into lp:~maas-maintainers/juju-core/maas-provider-skeleton has been updated.

Description changed to:

As suggested by William (and this is also the solution Jeroen and I had in mind for this),  this branch changes the userdata script so that a file containing the instanceID will be written by cloudinit, this file will then be picked up by jujud when running maasEnvironProvider.InstanceId so that jujud will be able to know the instanceID of the machine on which it is running.

The only "trick" is that I had to add another utility method in cloudinit.go so that the creation of the instanceID file will happen *before* jujud is started (jujud is indeed started by cloudinit as well).

This was tested in the lab and a bootstrap node (with the correct machineID file) successfully started.

After talking to William, he suggested, instead of adding AddRunCmdPrefix, to change cloudinit.New into cloudinit.Configure (and that new method would take an existing config as input instead of creating one).  That seems reasonable but I'd like to do that in a followup branch.

For more details, see:
https://code.launchpad.net/~rvb/juju-core/instanceID/+merge/157059
-- 
https://code.launchpad.net/~rvb/juju-core/instanceID/+merge/157059
Your team MAAS Maintainers is requested to review the proposed merge of lp:~rvb/juju-core/instanceID into lp:~maas-maintainers/juju-core/maas-provider-skeleton.