← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~stevenk/launchpad/xmlexport-all-specs into lp:launchpad

 

The proposal to merge lp:~stevenk/launchpad/xmlexport-all-specs into lp:launchpad has been updated.

Description changed to:

This MP builds on work started by Steve Langasek in https://code.launchpad.net/~vorlon/launchpad/lp.994110/+merge/105078. I disagree with Curtis, in that sometimes you do want to discuss a spec at a sprint, no matter the definition status because you're not sure if it is going to worked on that series at all -- you have no idea at that point, so the filtering is actively harmful. I have also fixed tests.

I have also done a drive-by cleaning up the render() method to look cleaner, and have cleaned up the comments I saw to fit our guidelines.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/xmlexport-all-specs/+merge/159061
-- 
https://code.launchpad.net/~stevenk/launchpad/xmlexport-all-specs/+merge/159061
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/xmlexport-all-specs into lp:launchpad.


References