launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/destroy-launchbagview into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/destroy-launchbagview/+merge/165022

Destroy LaunchBagView and the horse it rode in on.
-- 
https://code.launchpad.net/~stevenk/launchpad/destroy-launchbagview/+merge/165022
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/destroy-launchbagview into lp:launchpad.

=== modified file 'lib/lp/services/webapp/configure.zcml'
--- lib/lp/services/webapp/configure.zcml	2013-04-10 09:12:32 +0000
+++ lib/lp/services/webapp/configure.zcml	2013-05-22 07:50:37 +0000
@@ -261,14 +261,6 @@
         name="+opstats"
         />
 
-    <browser:page
-        for="*"
-        name="bag"
-        template="templates/launchbag-debug.pt"
-        permission="zope.Public"
-        class="lp.services.webapp.launchbag.LaunchBagView"
-        />
-
     <!-- Resource unnamed view, allowing Z3 preferred spelling
         /@@/launchpad-icon-small to access the images directory -->
     <browser:page

=== modified file 'lib/lp/services/webapp/launchbag.py'
--- lib/lp/services/webapp/launchbag.py	2013-04-10 04:29:01 +0000
+++ lib/lp/services/webapp/launchbag.py	2013-05-22 07:50:37 +0000
@@ -161,13 +161,6 @@
         return self._store.time_zone
 
 
-class LaunchBagView(object):
-    def __init__(self, context, request):
-        self.context = context
-        self.request = request
-        self.bag = getUtility(ILaunchBag)
-
-
 def set_login_in_launchbag_when_principal_identified(event):
     """This IPrincipalIdentifiedEvent subscriber sets 'login' in launchbag.
     """

=== removed file 'lib/lp/services/webapp/templates/launchbag-debug.pt'
--- lib/lp/services/webapp/templates/launchbag-debug.pt	2011-05-27 21:03:22 +0000
+++ lib/lp/services/webapp/templates/launchbag-debug.pt	1970-01-01 00:00:00 +0000
@@ -1,46 +0,0 @@
-<div
-  xmlns:tal="http://xml.zope.org/namespaces/tal";
-  xmlns:metal="http://xml.zope.org/namespaces/metal";
-  xmlns:i18n="http://xml.zope.org/namespaces/i18n";
-  class="portlet">
-    <h2>Context</h2>
-
-    <table tal:define="bag view/bag">
-        <tr>
-            <td>Site</td>
-            <td tal:content="bag/site/name|nothing" />
-        </tr>
-        <tr>
-            <td>Person</td>
-            <td tal:content="bag/person/displayname|nothing" />
-        </tr>
-        <tr>
-            <td>Project Group</td>
-            <td tal:content="bag/project/name|nothing" />
-        </tr>
-        <tr>
-            <td>Project</td>
-            <td tal:content="bag/product/name|nothing" />
-        </tr>
-        <tr>
-            <td>Distribution</td>
-            <td tal:content="bag/distribution/name|nothing" />
-        </tr>
-        <tr>
-            <td>DistroSeries</td>
-            <td tal:content="bag/distroseries/name|nothing" />
-        </tr>
-        <tr>
-            <td>Sourcepackage</td>
-            <td tal:content="bag/sourcepackage/name|nothing" />
-        </tr>
-        <tr>
-            <td>SourcePackageReleasePublishing</td>
-            <td tal:content="bag/sourcepackagereleasepublishing/name|nothing" />
-        </tr>
-        <tr>
-            <td>User</td>
-            <td tal:content="bag/user/displayname|nothing" />
-        </tr>
-    </table>
-</div>