launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/plus-queue-errors into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/plus-queue-errors/+merge/166164

DistroSeries:+queue does not display significant errors, it just hides the queue from rendering, so now it no longer hides the queue list and displays the error in a div.
-- 
https://code.launchpad.net/~stevenk/launchpad/plus-queue-errors/+merge/166164
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/plus-queue-errors into lp:launchpad.

=== modified file 'lib/lp/soyuz/templates/distroseries-queue.pt'
--- lib/lp/soyuz/templates/distroseries-queue.pt	2013-05-28 05:31:13 +0000
+++ lib/lp/soyuz/templates/distroseries-queue.pt	2013-05-29 02:37:28 +0000
@@ -32,7 +32,11 @@
                  message view/performQueueAction;
                  error view/error|nothing">
 
-  <div class="top-portlet queue_list" tal:condition="not: error">
+  <div class="error message" tal:condition="error">
+    <scan tal:content="error"></scan>
+  </div>
+
+  <div class="top-portlet queue_list">
 
     <tal:batch define="batch view/decoratedQueueBatch|nothing">