launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/distroseries-spec-preload into lp:launchpad has been updated.

Description changed to:

Rewrite preloading for searching specifications, allowing callsites to specify which of people, branches and workitems they need preloaded, modeled off IPersonSet.getPrecachedPersonsFromIDs().

IHasSpecification._valid_specifications has been renamed to valid_specifications and is no longer a property, and to ensure API compatability, api_valid_specifications is a property which calls into valid_specifications.

I've also re-enabled a disabled test that now works due to the refactoring work that went into search_specifications().

I have more than enough LoC credit to take the +50 hit for this branch.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/distroseries-spec-preload/+merge/180046
-- 
https://code.launchpad.net/~stevenk/launchpad/distroseries-spec-preload/+merge/180046
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/distroseries-spec-preload into lp:launchpad.