launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/builderinteractor-c-b-b into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Steve Kowalik <stevenk@xxxxxxxxxx>
Date: Wed, 28 Aug 2013 01:34:17 -0000
In-reply-to: <20130827075936.13117.39160.launchpad@ackee.canonical.com>
Reply-to: mp+182290@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

656	+ bq = build.queueBuild()
657	+ bq.markAsBuilding(builder)
658	+ interactor = BuilderInteractor(builder, slave)
659	+ d = interactor._startBuild(bq, BufferLogger())

This block is repeated twice in the same test, I'd prefer to see it refactored into a method like the one you replaced. Other than that, this branch looks great.
-- 
https://code.launchpad.net/~wgrant/launchpad/builderinteractor-c-b-b/+merge/182290
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/builderinteractor-c-b-b into lp:launchpad
From: William Grant, 2013-08-27