← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/failure-count-reset into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Sat, 31 Aug 2013 11:21:23 -0000
In-reply-to: <20130831111726.17246.98931.launchpad@ackee.canonical.com>
Reply-to: mp+183320@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code

The resume won't actually occur, because you don't pass back the Deferred returned by resetOrFail. Otherwise this looks fine, as long as the failnotes still have reasonable content.
-- 
https://code.launchpad.net/~cjwatson/launchpad/failure-count-reset/+merge/183320
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/failure-count-reset into lp:launchpad
From: Colin Watson, 2013-08-31