launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

I'd consider doing storeFile in one pass by writing to a temporary file first. We made a similar change in the other cache code to avoid leaving truncated files on failure, so it'd be a double win. But it's less important here.
-- 
https://code.launchpad.net/~cjwatson/launchpad-buildd/large-build-artifacts/+merge/186503
Your team Launchpad code reviewers is subscribed to branch lp:launchpad-buildd.