launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #16170
Re: [Merge] lp:~cjwatson/launchpad/configurable-germinate-base into lp:launchpad
On Thu, Nov 07, 2013 at 09:25:47PM -0000, Adam Conrad wrote:
> maintenance-check.py also hits people.canonical.com for the same reason, should probably be fixed to use the same config option.
It probably needs an additional one, because it points to
germinate-output as well as seeds and I'm a bit wary of hardcoding their
relative locations.
I'm also wary of changing anything substantial in maintenance-check
until it has tests worth the name, though. I should finish that
refactoring branch ...
--
https://code.launchpad.net/~cjwatson/launchpad/configurable-germinate-base/+merge/194340
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/configurable-germinate-base into lp:launchpad.
References