launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #16192
[Merge] lp:~stevenk/launchpad/delete-branch-title into lp:launchpad
Steve Kowalik has proposed merging lp:~stevenk/launchpad/delete-branch-title into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #761842 in Launchpad itself: "clicking "Delete Branch" shows truncated branch name"
https://bugs.launchpad.net/launchpad/+bug/761842
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/delete-branch-title/+merge/195170
Change Branch:+delete to show the branch displayname in the title, rather than just hardcoding "Delete branch" -- this meant that the user could only determine the branch being deleted by the URL, since the breadcrumb would truncate branch names.
--
https://code.launchpad.net/~stevenk/launchpad/delete-branch-title/+merge/195170
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/delete-branch-title into lp:launchpad.
=== modified file 'lib/lp/code/stories/branches/xx-branch-deletion.txt'
--- lib/lp/code/stories/branches/xx-branch-deletion.txt 2013-09-27 04:13:23 +0000
+++ lib/lp/code/stories/branches/xx-branch-deletion.txt 2013-11-14 04:55:33 +0000
@@ -37,7 +37,7 @@
>>> delete_link.click()
>>> print extract_text(find_main_content(browser.contents))
- Delete branch
+ Delete branch “lp://dev/~alice/earthlynx/to-delete”
Earth Lynx...
Branch deletion is permanent.
or Cancel
=== modified file 'lib/lp/code/templates/branch-delete.pt'
--- lib/lp/code/templates/branch-delete.pt 2010-02-22 22:11:07 +0000
+++ lib/lp/code/templates/branch-delete.pt 2013-11-14 04:55:33 +0000
@@ -7,9 +7,7 @@
i18n:domain="launchpad">
<body>
- <h1 metal:fill-slot="heading">
- Delete branch
- </h1>
+ <h1 metal:fill-slot="heading" tal:content="view/page_title"></h1>
<div metal:fill-slot="main">
Follow ups
