launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

38	+ processor = exported(
39	+ ReferenceChoice(
40	+ title=_("Processor"), required=True, vocabulary='Processor',
41	+ schema=IProcessor))

You probably want a readonly=True here.

The only other potential issue is preloading, but I suspect we haven't had cause to do that for DASes anywhere yet.
-- 
https://code.launchpad.net/~cjwatson/launchpad/export-das-processor/+merge/198935
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.