launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/testfix-export-das-processor into lp:launchpad.

Commit message:
Use a modified schema in DistroArchSeriesAddView now that IDistroArchSeries.processor is read-only.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/testfix-export-das-processor/+merge/199020

Fix test failures caused by making DAS.processor read-only in the process of exporting it.  Hopefully this is a reasonable way to go about it?
-- 
https://code.launchpad.net/~cjwatson/launchpad/testfix-export-das-processor/+merge/199020
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/testfix-export-das-processor into lp:launchpad.

=== modified file 'lib/lp/soyuz/browser/distroarchseries.py'
--- lib/lp/soyuz/browser/distroarchseries.py	2013-09-11 08:17:34 +0000
+++ lib/lp/soyuz/browser/distroarchseries.py	2013-12-14 05:28:53 +0000
@@ -13,6 +13,7 @@
     'DistroArchSeriesView',
     ]
 
+from lazr.restful.interface import copy_field
 from lazr.restful.utils import smartquote
 from zope.interface import (
     implements,
@@ -90,9 +91,15 @@
         return self.context.title
 
 
+class IDistroArchSeriesAddSchema(IDistroArchSeries):
+    """A tweaked schema for creating new DistroArchSeries."""
+
+    processor = copy_field(IDistroArchSeries['processor'], readonly=False)
+
+
 class DistroArchSeriesAddView(LaunchpadFormView):
 
-    schema = IDistroArchSeries
+    schema = IDistroArchSeriesAddSchema
     field_names = [
         'architecturetag', 'processor', 'official', 'supports_virtualized']