launchpad-reviewers team mailing list archive

[Celso Providelo <celso.providelo@xxxxxxxxxxxxx>]

Celso Providelo has proposed merging lp:~cprov/launchpad/db-add-cric-take2 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cprov/launchpad/db-add-cric-take2/+merge/200560


-- 
https://code.launchpad.net/~cprov/launchpad/db-add-cric-take2/+merge/200560
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cprov/launchpad/db-add-cric-take2 into lp:launchpad.

=== added file 'database/schema/patch-2209-53-0.sql'
--- database/schema/patch-2209-53-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-53-0.sql	2014-01-06 17:52:47 +0000
@@ -0,0 +1,30 @@
+-- Copyright 2013 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE TABLE codereviewinlinecomment (
+    previewdiff integer NOT NULL REFERENCES previewdiff,
+    person integer NOT NULL REFERENCES person,
+    comment integer PRIMARY KEY REFERENCES codereviewmessage,
+    comments text
+);
+
+CREATE INDEX codereviewinlinecomment__person__idx ON
+    codereviewinlinecomment(person);
+CREATE INDEX codereviewinlinecomment__previewdiff__idx ON
+    codereviewinlinecomment(previewdiff);
+
+CREATE TABLE codereviewinlinecommentdraft (
+    previewdiff integer NOT NULL REFERENCES previewdiff,
+    person integer NOT NULL REFERENCES person,
+    comments text,
+    PRIMARY KEY (previewdiff, person)
+);
+
+CREATE INDEX codereviewinlinecommentdraft__person__idx ON
+    codereviewinlinecommentdraft(person);
+CREATE INDEX codereviewinlinecommentdraft__previewdiff__idx ON
+    codereviewinlinecommentdraft(previewdiff);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 53, 0);

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2013-12-04 08:46:38 +0000
+++ database/schema/security.cfg	2014-01-06 17:52:47 +0000
@@ -169,6 +169,8 @@
 public.codeimportjob                    = SELECT, INSERT, UPDATE, DELETE
 public.codeimportmachine                = SELECT, INSERT, UPDATE
 public.codeimportresult                 = SELECT, INSERT, UPDATE, DELETE
+public.codereviewinlinecomment          = SELECT, INSERT, UPDATE, DELETE
+public.codereviewinlinecommentdraft     = SELECT, INSERT, UPDATE, DELETE
 public.codereviewmessage                = SELECT, INSERT, DELETE
 public.codereviewvote                   = SELECT, INSERT, UPDATE, DELETE
 public.combinedbugsummary               = SELECT