← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cprov/launchpad/private-branches-tips into lp:launchpad

 

Review: Approve code

`make lint reports some unused imports that you should remove, but otherwise this looks good. Welcome back!

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/model/distribution.py
  lib/lp/registry/model/distroseries.py
  lib/lp/registry/tests/test_distro_webservice.py

./lib/lp/registry/model/distribution.py
      51: 'PUBLIC_INFORMATION_TYPES' imported but unused
      51: 'PRIVATE_INFORMATION_TYPES' imported but unused
     145: 'quote' imported but unused
./lib/lp/registry/tests/test_distro_webservice.py
      10: 'getUtility' imported but unused
      15: 'ILaunchpadCelebrities' imported but unused
make: *** [lint] Error 5

-- 
https://code.launchpad.net/~cprov/launchpad/private-branches-tips/+merge/200530
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References