← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wgrant/launchpad/extend-ensurepresent-timeout into lp:launchpad

 

Review: Approve

Willian,

As discussed on IRC, the hardcoded timeout scale (*5) is a little evil, but is well isolated on the ensurepresent() scope.

As I said, withing the CI context, among jenkins and buildbot slaves (that are not that better in resilience), we could investigate a better build engine solution that fits our needs. Avoid flake synchronous operations that mostly lead to completely losing control of our resources during the timeout period.
-- 
https://code.launchpad.net/~wgrant/launchpad/extend-ensurepresent-timeout/+merge/200943
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References