launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/bug-1186349 into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Mon, 13 Jan 2014 22:52:47 -0000
In-reply-to: <20140113124325.1157.25576.launchpad@ackee.canonical.com>
Reply-to: mp+201381@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Willian,

It ended up requiring a lot of changes to simply add batching support to a page. One would expect pre-existing (correct) support for that kind of operation in the DecoratedResultSet engine.

I am glad you found time to add a more useful hook in the DecoratedResultSet. Looking forward to see the branch getting rid of pre_iter_hook.


-- 
https://code.launchpad.net/~wgrant/launchpad/bug-1186349/+merge/201381
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/bug-1186349 into lp:launchpad
From: William Grant, 2014-01-13