launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #16366
Re: [Merge] lp:~wgrant/launchpad/branch-unscan-api into lp:launchpad
Review: Approve
Thanks for the feature. Just minor remarks for your consideration:
* What was the problem with simplejson on tests ?
* assertIsNone(xxx) reads better than assertIs(None, xxx)
--
https://code.launchpad.net/~wgrant/launchpad/branch-unscan-api/+merge/201704
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References