launchpad-reviewers team mailing list archive

[Celso Providelo <celso.providelo@xxxxxxxxxxxxx>]

Celso Providelo has proposed merging lp:~cprov/launchpad/cric-api-take2 into lp:launchpad.

Requested reviews:
  Celso Providelo (cprov)

For more details, see:
https://code.launchpad.net/~cprov/launchpad/cric-api-take2/+merge/202478

Testfix
-- 
https://code.launchpad.net/~cprov/launchpad/cric-api-take2/+merge/202478
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/code/browser/codereviewcomment.py'
--- lib/lp/code/browser/codereviewcomment.py	2014-01-14 04:27:19 +0000
+++ lib/lp/code/browser/codereviewcomment.py	2014-01-21 15:00:35 +0000
@@ -284,14 +284,18 @@
         """Create the comment..."""
         vote = data.get('vote')
         review_type = data.get('review_type')
-        publish_inline_comments = False
+        inline_comments = {}
+        diff_timestamp = None
         if (getFeatureFlag('code.inline_diff_comments.enabled') and
             data.get('publish_inline_comments')):
-            publish_inline_comments = True
+            diff_timestamp = self.previewdiff.date_created
+            inline_comments = (
+                self.branch_merge_proposal.getDraftInlineComments(
+                    diff_timestamp))
         comment = self.branch_merge_proposal.createComment(
             self.user, subject=None, content=data['comment'],
             parent=self.reply_to, vote=vote, review_type=review_type,
-            publish_inline_comments=publish_inline_comments)
+            diff_timestamp=diff_timestamp, inline_comments=inline_comments)
 
     @property
     def next_url(self):