launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/faceted-breadcrumbs into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Tue, 18 Feb 2014 13:21:16 -0000
In-reply-to: <20140218123535.9286.13275.launchpad@ackee.canonical.com>
Reply-to: mp+206916@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Such a clever change! Now we have breadcrumb adapters tagged by facet names instead of vhosts.

Perhaps we could use this opportunity to also rename the factory classes <Thing>VHostBreadcrumb to <Thing>FacetBreadcrumb just for the cleanness of terms.

-- 
https://code.launchpad.net/~wgrant/launchpad/faceted-breadcrumbs/+merge/206916
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/faceted-breadcrumbs into lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/faceted-breadcrumbs into lp:launchpad
From: William Grant, 2014-02-18