launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/no-cscvs-svn into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2014 23:57:25 -0000
In-reply-to: <20140224073622.26729.17624.launchpad@ackee.canonical.com>
Reply-to: mp+207873@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

It is always good to have less code.

As you stated on IRC, we still need subvertpy for bzr-svn, so the dependency remains in setup.py a CSCVS still needed as long as we have over 600 (!!) CVS active imports.

The old subversion imports via CSCVS records will remain in DB for historical purposes and we will be able to list them properly since basic identification-code was not removed.

If something was left behind, which is quite acceptable considering the code complexity, there are good assertions in place and we will notice in oops. 
-- 
https://code.launchpad.net/~wgrant/launchpad/no-cscvs-svn/+merge/207873
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/no-cscvs-svn into lp:launchpad
From: William Grant, 2014-02-24