launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bug-1284467 into lp:launchpad.

Commit message:
Move a couple more IBugTarget attributes from Product's launchpad.View to launchpad.LimitedView, as the BugTask:+index duplicate portlet uses eg. searchTasks.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1284467 in Launchpad itself: "BugView.duplicates fails with Unauthorized for users with just an artifact grant on the bug"
  https://bugs.launchpad.net/launchpad/+bug/1284467

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/bug-1284467/+merge/208066

Move a couple more IBugTarget attributes from Product's launchpad.View to launchpad.LimitedView, as the BugTask:+index duplicate portlet uses eg. searchTasks.
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-1284467/+merge/208066
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bug-1284467 into lp:launchpad.

=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2014-02-18 11:40:52 +0000
+++ lib/lp/registry/configure.zcml	2014-02-25 06:30:57 +0000
@@ -1375,20 +1375,20 @@
         <require
             permission="launchpad.LimitedView"
             attributes="
-                bugtargetdisplayname"/>
-
-        <require
-            permission="launchpad.View"
-            attributes="
-                bug_reported_acknowledgement
-                bug_reporting_guidelines
-                bugtargetname
-                createBug
-                enable_bugfiling_duplicate_search
+                bugtargetdisplayname
                 getBugTaskWeightFunction
                 pillar
                 searchTasks"/>
 
+        <require
+            permission="launchpad.View"
+            attributes="
+                bug_reported_acknowledgement
+                bug_reporting_guidelines
+                bugtargetname
+                createBug
+                enable_bugfiling_duplicate_search"/>
+
         <!-- IHasAliases -->
 
         <require