launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/no-custom-xmlrpc-rooturl into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Thu, 27 Feb 2014 02:34:55 -0000
In-reply-to: <20140116073225.14780.56271.launchpad@ackee.canonical.com>
Reply-to: mp+201891@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Nice!

I presume you will coordinate with webops to get those changes propagated to production configs at some point after it gets released.

I am assuming (by the code) it won't break existing code with old-style configs because you have modified getRootURL() do operate properly for 'special' hosts independently of the config.rooturl.

Nonetheless, it will be great to have 'sane' configuration for those hosts in production.
-- 
https://code.launchpad.net/~wgrant/launchpad/no-custom-xmlrpc-rooturl/+merge/201891
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/no-custom-xmlrpc-rooturl into lp:launchpad
From: William Grant, 2014-01-16