launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/no-alllocks into lp:launchpad.

Commit message:
Drop the unused alllocks and exclusivelocks views, as their use of pg_stat_activity.procpid crashes pg_upgrade to 9.3 due to the column rename.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/no-alllocks/+merge/208569

Drop the unused alllocks and exclusivelocks views, as their use of pg_stat_activity.procpid crashes pg_upgrade to 9.3 due to the column rename.
-- 
https://code.launchpad.net/~wgrant/launchpad/no-alllocks/+merge/208569
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/no-alllocks into lp:launchpad.

=== added file 'database/schema/patch-2209-53-4.sql'
--- database/schema/patch-2209-53-4.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-53-4.sql	2014-02-27 11:05:22 +0000
@@ -0,0 +1,9 @@
+-- Copyright 2014 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+DROP VIEW exclusivelocks;
+DROP VIEW alllocks;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 53, 4);

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2014-01-15 18:09:00 +0000
+++ database/schema/security.cfg	2014-02-27 11:05:22 +0000
@@ -14,7 +14,6 @@
 public.accessartifact_denorm_to_artifacts(integer) = EXECUTE
 public.activity()                          = EXECUTE
 public.add_test_openid_identifier(integer) = EXECUTE
-public.alllocks                            =
 public.assert_patch_applied(integer, integer, integer) = EXECUTE
 public.branch_denorm_access(integer)       = EXECUTE
 public.build_access_cache(integer, integer) =
@@ -42,7 +41,6 @@
 public.debversionout(debversion)                       = EXECUTE
 public.debversionrecv(internal)                        = EXECUTE
 public.debversionsend(debversion)                      = EXECUTE
-public.exclusivelocks                      =
 public.featureflag                         = SELECT
 public.fticache                            =
 public.ftq(text)                           = EXECUTE