launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #16507
Re: [Merge] lp:~cprov/launchpad/diff-navigator into lp:launchpad
I think I have addressed all the initial review issues.
It is now rendering the diff navigator <select> on client-side and the content is not that bad for a initial release, although we could use something similar to fmt:displaydate leveraging Y.Intl & Y.Date features.
You have mentioned the possibility of embedding the inline comments in the actual review comment, similarly to what is done by Gerrit.
We can tackle this and other enhancing features in subsequent branches, assuming we agree that this UI change is well controlled by a feature-flag and can be available in staging for internal experimentation.
--
https://code.launchpad.net/~cprov/launchpad/diff-navigator/+merge/208186
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References