launchpad-reviewers team mailing list archive

[Celso Providelo <celso.providelo@xxxxxxxxxxxxx>]

Celso Providelo has proposed merging lp:~cprov/launchpad/p3a-api-token into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1290543 in Launchpad itself: "getArchiveSubscriptionURL(archive) should return the generated URL, not the user information"
  https://bugs.launchpad.net/launchpad/+bug/1290543

For more details, see:
https://code.launchpad.net/~cprov/launchpad/p3a-api-token/+merge/210303
-- 
https://code.launchpad.net/~cprov/launchpad/p3a-api-token/+merge/210303
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cprov/launchpad/p3a-api-token into lp:launchpad.

=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2014-03-07 01:35:46 +0000
+++ lib/lp/registry/interfaces/person.py	2014-03-11 00:05:07 +0000
@@ -1048,7 +1048,7 @@
     @call_with(requester=REQUEST_USER)
     @operation_parameters(
         archive=Reference(schema=Interface))  # Really IArchive
-    @export_write_operation()
+    @export_read_operation()
     @operation_for_version("beta")
     def getArchiveSubscriptionURL(requester, archive):
         """Get a text line that is suitable to be used for a sources.list

=== modified file 'lib/lp/soyuz/stories/webservice/xx-archive-commercial.txt'
--- lib/lp/soyuz/stories/webservice/xx-archive-commercial.txt	2014-03-07 01:35:46 +0000
+++ lib/lp/soyuz/stories/webservice/xx-archive-commercial.txt	2014-03-11 00:05:07 +0000
@@ -47,7 +47,7 @@
 The agent can query the sources.list entry for an archive for any user, which
 will include an AuthToken, and create it if needed:
 
-    >>> response = agent_webservice.named_post(
+    >>> response = agent_webservice.named_get(
     ...   joe['self_link'], 'getArchiveSubscriptionURL', {},
     ...   archive=cp3a['self_link'])
     >>> print response
@@ -66,7 +66,7 @@
 
 Joe can query his own entry:
 
-    >>> response = joe_webservice.named_post(
+    >>> response = joe_webservice.named_get(
     ...   joe['self_link'], 'getArchiveSubscriptionURL', {},
     ...   archive=cp3a['self_link'])
     >>> print response
@@ -76,7 +76,7 @@
 
 But Joe can not query the entry of cprov:
 
-    >>> response = joe_webservice.named_post(
+    >>> response = joe_webservice.named_get(
     ...   cprov['self_link'], 'getArchiveSubscriptionURL', {},
     ...   archive=cp3a['self_link'])
     >>> print response