launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Chris Johnston has proposed merging lp:~cjohnston/launchpad/1244636 into lp:launchpad.

Commit message:
Removes the private security bug notice from a public security bug

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1244636 in Launchpad itself: "creating a "Public Security" bug shows a tooltip saying that the bug is private"
  https://bugs.launchpad.net/launchpad/+bug/1244636

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/1244636/+merge/213574

Currently Launchpad shows a message about security bugs being private by default even when reporting a public security bug. This is confusing behavior.
-- 
https://code.launchpad.net/~cjohnston/launchpad/1244636/+merge/213574
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/1244636 into lp:launchpad.

=== modified file 'lib/lp/bugs/browser/bugtarget.py'
--- lib/lp/bugs/browser/bugtarget.py	2014-02-24 06:50:46 +0000
+++ lib/lp/bugs/browser/bugtarget.py	2014-04-01 03:43:26 +0000
@@ -63,7 +63,6 @@
     InformationType,
     PRIVATE_INFORMATION_TYPES,
     PUBLIC_INFORMATION_TYPES,
-    SECURITY_INFORMATION_TYPES,
     ServiceUsage,
     )
 from lp.app.errors import (
@@ -640,7 +639,7 @@
         # Give the user some feedback on the bug just opened.
         for notification in notifications:
             self.request.response.addNotification(notification)
-        if bug.information_type in SECURITY_INFORMATION_TYPES:
+        if bug.information_type == InformationType.PRIVATESECURITY:
             self.request.response.addNotification(
                 structured(
                 'Security-related bugs are by default private '