launchpad-reviewers team mailing list archive

[Chris Johnston <chris.johnston@xxxxxxxxxxxxx>]

Chris Johnston has proposed merging lp:~cjohnston/launchpad/572017 into lp:launchpad.

Commit message:
Switch to show that you can assign a new branch

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #572017 in Launchpad itself: "new code import form for admins says "you can *re*assign this branch to any person or team""
  https://bugs.launchpad.net/launchpad/+bug/572017

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/572017/+merge/213941

You can't reassign a branch that was never assigned.
-- 
https://code.launchpad.net/~cjohnston/launchpad/572017/+merge/213941
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/572017 into lp:launchpad.

=== modified file 'lib/lp/code/browser/branch.py'
--- lib/lp/code/browser/branch.py	2014-02-24 07:19:52 +0000
+++ lib/lp/code/browser/branch.py	2014-04-02 23:15:21 +0000
@@ -1133,7 +1133,7 @@
             owner_field = self.schema['owner']
             any_owner_choice = Choice(
                 __name__='owner', title=owner_field.title,
-                description=_("As an administrator you are able to reassign"
+                description=_("As an administrator you are able to assign"
                                 " this branch to any person or team."),
                 required=True, vocabulary='ValidPersonOrTeam')
             any_owner_field = form.Fields(

=== modified file 'lib/lp/code/browser/sourcepackagerecipe.py'
--- lib/lp/code/browser/sourcepackagerecipe.py	2013-08-22 01:26:23 +0000
+++ lib/lp/code/browser/sourcepackagerecipe.py	2014-04-02 23:15:21 +0000
@@ -884,7 +884,7 @@
             owner_field = self.schema['owner']
             any_owner_choice = PersonChoice(
                 __name__='owner', title=owner_field.title,
-                description=(u"As an administrator you are able to reassign"
+                description=(u"As an administrator you are able to assign"
                              u" this branch to any person or team."),
                 required=True, vocabulary='ValidPersonOrTeam')
             any_owner_field = form.Fields(