← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~cjohnston/launchpad/617209 into lp:launchpad

 

Chris Johnston has proposed merging lp:~cjohnston/launchpad/617209 into lp:launchpad.

Commit message:
Change total PPA figure from dispatched to created since it includes superseeded

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #617209 in Launchpad itself: ""Package build summary" displays incorrect value for the total number of builds dispatched for PPA"
  https://bugs.launchpad.net/launchpad/+bug/617209

For more details, see:
https://code.launchpad.net/~cjohnston/launchpad/617209/+merge/213961
-- 
https://code.launchpad.net/~cjohnston/launchpad/617209/+merge/213961
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjohnston/launchpad/617209 into lp:launchpad.
=== modified file 'lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt'
--- lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt	2013-08-01 00:14:03 +0000
+++ lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt	2014-04-03 02:27:19 +0000
@@ -70,7 +70,7 @@
     ...     anon_browser.contents, "View all builds Package build summary")
     >>> print extract_text(build_summary)
     View...
-    A total of 4 builds have been dispatched for this PPA.
+    A total of 4 builds have been created for this PPA.
     Completed builds
     3 successful
     1 failed

=== modified file 'lib/lp/soyuz/templates/archive-macros.pt'
--- lib/lp/soyuz/templates/archive-macros.pt	2013-05-01 17:09:37 +0000
+++ lib/lp/soyuz/templates/archive-macros.pt	2014-04-03 02:27:19 +0000
@@ -254,7 +254,7 @@
     <p>A total of
       <span class="build-count total"
             tal:content="view/build_counters/total">100</span> builds have
-      been dispatched for this PPA.</p>
+      been created for this PPA.</p>
 
     <dl>
       <dt>Completed builds</dt>


Follow ups