launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjohnston/launchpad/ic-view into lp:launchpad

To: Chris Johnston <chris.johnston@xxxxxxxxxxxxx>
From: Celso Providelo <celso.providelo@xxxxxxxxxxxxx>
Date: Wed, 09 Apr 2014 20:05:16 -0000
In-reply-to: <20140408230922.17593.14103.launchpad@ackee.canonical.com>
Reply-to: mp+214851@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks great, Chris!

I am not particularly sure about the font & line-height changes at this point, because they make inline comments too sparse. But that's more a personal taste issue than a opposition to land the changes.

Soon we will get some time with UI experts and they will guide the final tweaks to get this released.

Thanks for working on this.

 
-- 
https://code.launchpad.net/~cjohnston/launchpad/ic-view/+merge/214851
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjohnston/launchpad/ic-view into lp:launchpad
From: Chris Johnston, 2014-04-08