← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wgrant/launchpad/kill-bpb-is_new into lp:launchpad

 

Review: Approve

Nice cleanup!

There is a weird behaviour of makeBinaryPackageUpload() in the test that forces you to check properties of the *second* binary (when it should be only one). But that is unrelated to this change and surely manifest itself in many other tests, let's fix it later.

-- 
https://code.launchpad.net/~wgrant/launchpad/kill-bpb-is_new/+merge/215069
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References